I'm writing a program to play Connect Four with Python and I'm not sure how to resolve the "expected an indented block" error that is being thrown at me in certain areas. Any time I try running a [row][col] section, it throws the error up. I'm using some example code to help me develop my own and here's what I'm using:
import random
def winner(board):
"""This function accepts the Connect 4 board as a parameter.
If there is no winner, the function will return the empty string "".
If the user has won, it will return 'X', and if the computer has
won it will return 'O'."""
# Check rows for winner
for row in range(6):
for col in range(3):
if (board[row][col] == board[row][col + 1] == board[row][col + 2] ==\
board[row][col + 3]) and (board[row][col] != " "):
return board[row][col]
# Check columns for winner
for col in range(6):
for row in range(3):
if (board[row][col] == board[row + 1][col] == board[row + 2][col] ==\
board[row + 3][col]) and (board[row][col] != " "):
return board[row][col]
# Check diagonal (top-left to bottom-right) for winner
for row in range(3):
for col in range(4):
if (board[row][col] == board[row + 1][col + 1] == board[row + 2][col + 2] ==\
board[row + 3][col + 3]) and (board[row][col] != " "):
return board[row][col]
# Check diagonal (bottom-left to top-right) for winner
for row in range(5, 2, -1):
for col in range(3):
if (board[row][col] == board[row - 1][col + 1] == board[row - 2][col + 2] ==\
board[row - 3][col + 3]) and (board[row][col] != " "):
return board[row][col]
# No winner: return the empty string
return ""
def display_board(board):
print " 1 2 3 4 5 6 7"
print "1: " + board[0][0] + " | " + board[0][1] + " | " + board[0][2] + " | " + board[0][3] + " | " + board[0][4] + " | " + board[0][5] + " | " + board[0][6] + " | " + board[0][7]
print " ---+---+---+---+---+---+---"
print "2: " + board[1][0] + " | " + board[1][1] + " | " + board[1][2] + " | " + board[1][3] + " | " + board[1][4] + " | " + board[1][5] + " | " + board [1][6] + " | " + board [1][7]
print " ---+---+---+---+---+---+---+"
print "3: " + board[2][0] + " | " + board[2][1] + " | " + board[2][2] + " | " + board[2][3] + " | " + board [2][4] + " | " + board [2][5] + " | " + board [2][6] + " | " + board [2][7]
print " ---+---+---+---+---+---+---+"
print "4: " + board[3][0] + " | " + board[3][1] + " | " + board[3][2] + " | " + board[3][3] + " | " + board [3][4] + " | " + board [3][5] + " | " + board [3][6] + " | " + board [3][7]
print " ---+---+---+---+---+---+---+"
print "5: " + board[4][0] + " | " + board[4][1] + " | " + board[4][2] + " | " + board[4][3] + " | " + board [4][4] + " | " + board [4][5] + " | " + board [4][6] + " | " + board [4][7]
print " ---+---+---+---+---+---+---+"
print "6: " + board[5][0] + " | " + board[5][1] + " | " + board[5][2] + " | " + board[5][3] + " | " + board [5][4] + " | " + board [5][5] + " | " + board [5][6] + " | " + board [5][7]
print
def make_user_move(board):
try:
valid_move = False
while not valid_move:
col = input("What col would you like to move to (1-7):")
for row in range (6,0,-1):
if (1 <= row <= 6) and (1 <= col <= 7) and (board[row-1][col-1] == " "):
board[row-1][col-1] = 'X'
valid_move = True
break
else:
print "Sorry, invalid square. Please try again!\n"
except NameError:
print "Only numbers are allowed."
except IndexError:
print "You can only select columns from (1-7), and rows from (1-6)."
def make_computer_move(board):
# Code needed here...
valid_move = False
while not valid_move:
row = random.randint(0,5)
col = random.randint(0, 6)
for row in range (5,0,-1):
if board[row][col] == " ":
board[row][col] = "O"
valid_move = True
break
def main():
free_cells = 42
users_turn = True
count = 1
ttt_board = [ [ " ", " ", " ", " ", " ", " "," ", " "], [ " ", " ", " ", " ", " "," ", " ", " "], [ " ", " ", " ", " ", " ", " ", " ", " "], [ " ", " ", " ", " ", " ", " ", " ", " "], [ " ", " ", " ", " ", " ", " ", " ", " "], [ " ", " ", " ", " ", " ", " ", " ", " "] ]
print "\nHALL OF FAME \n"
try:
hall_of_fame = open("HallOfFame.txt", 'r')
for name in hall_of_fame:
print str(count) + ".", name
print
count += 1
hall_of_fame.close()
except IOError:
print "No Human Has Ever Beat Me.. mwah-ha-ha-ha!\n"
choice = raw_input("Would you like to go first? (y or n): ")
if (choice == 'y' or choice=='Y'):
users_turn = True
elif (choice == 'n' or choice =='N') :
users_turn = False
else:
print 'invalid input'
while not winner(ttt_board) and (free_cells > 0):
display_board(ttt_board)
if users_turn:
make_user_move(ttt_board)
users_turn = not users_turn
else:
make_computer_move(ttt_board)
users_turn = not users_turn
free_cells -= 1
display_board(ttt_board)
if (winner(ttt_board) == 'X'):
print "You Won!"
print "Your name will now be added to the Hall of Fame!"
hall_of_fame = open("HallOfFame.txt", 'a')
name = raw_input("Enter your name: ")
hall_of_fame.write(name+ '\n')
print "Your name has been added to the Hall of Fame!"
hall_of_fame.close()
print "\nGAME OVER"
elif (winner(ttt_board) == 'O'):
print "The Computer Won!"
print "\nGAME OVER"
else:
print "Stalemate!"
print "\nGAME OVER \n"
#start the game
main()
It looks like you are not indenting your for loops:
for row in range(6):
for col in range(3):
if (board[row][col] == board[row][col + 1] == board[row][col + 2] ==\
board[row][col + 3]) and (board[row][col] != " "):
return board[row][col]
The : denotes the need for an indent on the next line.
There are a LOT of places where the indentation is just plain missing for inexplicable reasons. As #davidism mentions, indentation in python is used to indicate nesting levels; so this code is completely unusable in its current state.
Here's my attempt to GUESS what your code was MEANT to do, so you can get an idea of all the places where whitespace matters, but it is just missing in your code.
import random
def winner(board):
for row in range(6):
for col in range(3):
if (board[row][col] == board[row][col + 1] == board[row][col + 2] == \
board[row][col + 3]) and (board[row][col] != " "):
return board[row][col] # Check columns for winner
for col in range(6):
for row in range(3):
if (board[row][col] == board[row + 1][col] == board[row + 2][col] == \
board[row + 3][col]) and (board[row][col] != " "):
return board[row][col]
# Check diagonal (top-left to bottom-right) for winner
for row in range(3):
for col in range(4):
if (board[row][col] == board[row + 1][col + 1] == board[row + 2][col + 2] == \
board[row + 3][col + 3]) and (board[row][col] != " "):
return board[row][col]
# Check diagonal (bottom-left to top-right) for winner
for row in range(5, 2, -1):
for col in range(3):
if (board[row][col] == board[row - 1][col + 1] == board[row - 2][col + 2] == \
board[row - 3][col + 3]) and (board[row][col] != " "):
return board[row][col]
# No winner: return the empty string
return ""
def display_board(board):
print " 1 2 3 4 5 6 7"
print "1: " + board[0][0] + " | " + board[0][1] + " | " + board[0][2] + " | " + board[0][3] + " | " + board[0][
4] + " | " + board[0][5] + " | " + board[0][6] + " | " + board[0][7]
print " ---+---+---+---+---+---+---"
print "2: " + board[1][0] + " | " + board[1][1] + " | " + board[1][2] + " | " + board[1][3] + " | " + board[1][
4] + " | " + board[1][5] + " | " + board[1][6] + " | " + board[1][7]
print " ---+---+---+---+---+---+---+"
print "3: " + board[2][0] + " | " + board[2][1] + " | " + board[2][2] + " | " + board[2][3] + " | " + board[2][
4] + " | " + board[2][5] + " | " + board[2][6] + " | " + board[2][7]
print " ---+---+---+---+---+---+---+"
print "4: " + board[3][0] + " | " + board[3][1] + " | " + board[3][2] + " | " + board[3][3] + " | " + board[3][
4] + " | " + board[3][5] + " | " + board[3][6] + " | " + board[3][7]
print " ---+---+---+---+---+---+---+"
print "5: " + board[4][0] + " | " + board[4][1] + " | " + board[4][2] + " | " + board[4][3] + " | " + board[4][
4] + " | " + board[4][5] + " | " + board[4][6] + " | " + board[4][7]
print " ---+---+---+---+---+---+---+"
print "6: " + board[5][0] + " | " + board[5][1] + " | " + board[5][2] + " | " + board[5][3] + " | " + board[5][
4] + " | " + board[5][5] + " | " + board[5][6] + " | " + board[5][7]
print
def make_user_move(board):
try:
valid_move = False
while not valid_move:
col = input("What col would you like to move to (1-7):")
for row in range(6, 0, -1):
if (1 <= row <= 6) and (1 <= col <= 7) and (board[row - 1][col - 1] == " "):
board[row - 1][col - 1] = 'X'
valid_move = True
break
else:
print "Sorry, invalid square. Please try again!\n"
except NameError:
print "Only numbers are allowed."
except IndexError:
print "You can only select columns from (1-7), and rows from (1-6)."
def make_computer_move(board):
# Code needed here...
valid_move = False
while not valid_move:
row = random.randint(0, 5)
col = random.randint(0, 6)
for row in range(5, 0, -1):
if board[row][col] == " ":
board[row][col] = "O"
valid_move = True
break
def main():
free_cells = 42
users_turn = True
count = 1
ttt_board = [[" ", " ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " ", " "],
[" ", " ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " ", " "],
[" ", " ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " ", " "]]
print "\nHALL OF FAME \n"
try:
hall_of_fame = open("HallOfFame.txt", 'r')
for name in hall_of_fame:
print str(count) + ".", name
print
count += 1
hall_of_fame.close()
except IOError:
print "No Human Has Ever Beat Me.. mwah-ha-ha-ha!\n"
choice = raw_input("Would you like to go first? (y or n): ")
if (choice == 'y' or choice == 'Y'):
users_turn = True
elif (choice == 'n' or choice == 'N'):
users_turn = False
else:
print 'invalid input'
while not winner(ttt_board) and (free_cells > 0):
display_board(ttt_board)
if users_turn:
make_user_move(ttt_board)
users_turn = not users_turn
else:
make_computer_move(ttt_board)
users_turn = not users_turn
free_cells -= 1
display_board(ttt_board)
if (winner(ttt_board) == 'X'):
print "You Won!"
print "Your name will now be added to the Hall of Fame!"
hall_of_fame = open("HallOfFame.txt", 'a')
name = raw_input("Enter your name: ")
hall_of_fame.write(name + '\n')
print "Your name has been added to the Hall of Fame!"
hall_of_fame.close()
print "\nGAME OVER"
elif (winner(ttt_board) == 'O'):
print "The Computer Won!"
print "\nGAME OVER"
else:
print "Stalemate!"
print "\nGAME OVER \n"
# start the game
main()
Related
Traceback (most recent call last):
File "RoomCheck.py", line 4, in <module>
from grove_rgb_lcd import *
File "build/bdist.linux-armv7l/egg/grove_rgb_lcd.py", line 33, in <module>
...skip
These errors are generated.
I've also attached the error capture:
Code:
from flask import Flask
from flask import render_template
from grovepi import *
from grove_rgb_lcd import *
import RPi.GPIO as GPIO
GPIO.setmode(GPIO.BCM)
app = Flask(__name__)
#app.route("/read/<port>")
def readGpio(port):
try:
GPIO.setup(int(port), GPIO.IN)
if GPIO.input(int(port)) == True:
AHour = 0
AMin = 0
BHour =0
BMin = 0
A_Check = 0
B_Check = 0
if port == 4:
if A_Check == 0:
A_Check = 1
setRGB(0,128,64)
setRGB(0,255,0)
setText("A goes out")
res = "A_Check is" + A_Check +"\n" + "B_Check is" +
B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
else:
A_Check = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("A cames in")
AHour = 0
AMin = 0
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
elif port ==17:
AHour += 1
if AHour > 24:
AHour = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("A : " + AHour + "H" + AMin + "M")
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
elif port ==27:
AMin += 5
if AMin>60:
AMin = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("A : " + AHour + "H" + AMin + "M")
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
elif port ==23:
if B_Check == 0:
B_Check = 1
setRGB(0,128,64)
setRGB(0,255,0)
setText("B goes out")
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
else:
B_Check = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("B cames in")
BHour = 0
BMin = 0
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
elif port ==24:
BHour += 1
if BHour > 24:
BHour = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("B : " + BHour + "H" + BMin + "M")
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
elif port ==25:
BMin += 5
if BMin>60:
BMin = 0
setRGB(0,128,64)
setRGB(0,255,0)
setText("B : " + BHour + "H" + BMin + "M")
res = "A_Check is" + A_Check +"\n" + "B_Check is" + B_Check +"\n" + "A : " + AHour + "H" + AMin + "M" +"\n" + "B : " + BHour + "H" + BMin + "M"
except:
res = "Read error from GPIO " + port + "."
templateData = {
'title' : 'Check our RoomMate',
'res' : res
}
return render_template('gpio.html', **templateData)
if __name__ == "__main__":
app.run(host='0.0.0.0', port=8888, debug=True)
I've been playing around with some code and recently found this issue out, once this code runs it returns "None" right under the players name and health, I've been trying to figure out why and changed a lot of the code but the issue still remains, does anyone know why this might be? much appreciated!
import random
import math
import os
import time
def return_health(name, health, maxHealth, healthDashes):
dashConvert = int(maxHealth/healthDashes)
currentDashes = int(health/dashConvert)
remainingHealth = healthDashes - currentDashes
healthDisplay = '-' * currentDashes
remainingDisplay = ' ' * remainingHealth
percent = str(int((health/maxHealth)*100)) + "%"
print(name+" "+"|" + healthDisplay + remainingDisplay + "|")
print(" " + percent)
class Player():
def __init__(self, name, maxhealth, health, healthdashes, offense, jutsu1, jutsu2, jutsu3):
self.name = name
self.maxhealth = maxhealth
self.health = health
self.healthdashes = healthdashes
self.offense = offense
self.jutsu1 = jutsu1
self.jutsu2 = jutsu2
self.jutsu3 = jutsu3
class Jutsu():
def __init__(self, name, damage):
self.name = name
self.damage = damage
## Jutsu's
Rasengan = Jutsu("Rasengan", 15)
Rasenshuriken = Jutsu("Rasenshuriken", 30)
VermillionRasengan = Jutsu("Vermillion Rasengan", 50)
Chidori = Jutsu("Chidori", 15)
OnxyChidori = Jutsu("Onxy Chidori", 30)
SusanoArrow = Jutsu("Susano's Arrow", 50)
## Player's
Naruto = Player("Naruto Uzumaki", 100, 100, 20, 10, Rasengan, Rasenshuriken,
VermillionRasengan)
Sasuke = Player("Sasuke Uchiha", 100, 100, 20, 10, Chidori, OnxyChidori, SusanoArrow)
def fight(player1, player2):
os.system("clear")
while True:
if player1.health <= 0:
os.system("clear")
print(player1.name + " has been defeated.")
time.sleep(3)
break
elif player2.health <= 0:
os.system("clear")
print(player2.name + " has been defeated")
time.sleep(3)
else:
print(return_health(player1.name, player1.health, player1.maxhealth, player1.healthdashes))
print(return_health(player2.name, player2.health, player2.maxhealth, player2.healthdashes))
print(player1.name + "'s turn.'")
print()
print("Choose your move!")
print("1. Attack" + " : " + str(+player1.offense))
print("2. " + player1.jutsu1.name + " : " +
str(+player1.jutsu1.damage))
print("3. " + player1.jutsu2.name + " : " +
str(+player1.jutsu2.damage))
print("4. " + player1.jutsu3.name + " : " +
str(+player1.jutsu3.damage))
choice = input("> ")
os.system("clear")
if choice == "1":
print(player1.name + " has attacked " + player2.name +
" for " + str(player1.offense) + " damage.")
player2.health -= player1.offense
elif choice == "2":
print(player1.name + " attacked " + player2.name + " with " +
player1.jutsu1.name + " for " +
str(player1.jutsu1.damage) + " damage.")
player2.health -= player1.jutsu1.damage
elif choice == "3":
print(player1.name + " attacked " + player2.name + " with " +
player1.jutsu2.name + " for " +
str(player1.jutsu2.damage) + " damage.")
player2.health -= player1.jutsu2.damage
elif choice == "4":
print(player1.name + " attacked " + player2.name + " with " +
player1.jutsu3.name + " for " +
str(player1.jutsu3.damage) + " damage.")
player2.health -= player1.jutsu3.damage
time.sleep(2)
os.system("clear")
if player2.health <= 0:
os.system("clear")
print(player2.name + " has been defeated.")
time.sleep(3)
break
else:
print(player2.name + " : " + str(player2.health))
print(player1.name + " : " + str(player1.health))
print(player2.name + "'s turn.'")
print()
print("Choose your move!")
print("1. Attack" + " : " + str(+player2.offense))
print("2. " + player2.jutsu1.name + " : " +
str(+player2.jutsu1.damage))
print("3. " + player2.jutsu2.name + " : " +
str(+player2.jutsu2.damage))
print("4. " + player2.jutsu3.name + " : " +
str(+player2.jutsu3.damage))
choice = input("> ")
os.system("clear")
if choice == "1":
print(player2.name + " has attacked " + player1.name +
" for " + str(player2.offense) + " damage.")
player1.health -= player2.offense
elif choice == "2":
print(player2.name + " attacked " + player1.name +
" with " + player2.jutsu1.name + " for " +
str(player2.jutsu1.damage) + " damage.")
player1.health -= player2.jutsu1.damage
elif choice == "3":
print(player2.name + " attacked " + player1.name +
" with " + player2.jutsu2.name + " for " +
str(player2.jutsu2.damage) + " damage.")
player1.health -= player2.jutsu2.damage
elif choice == "4":
print(player2.name + " attacked " + player1.name +
" with " + player2.jutsu3.name + " for " +
str(player2.jutsu3.damage) + " damage.")
player1.health -= player2.jutsu3.damage
time.sleep(2)
os.system("clear")
fight(Naruto, Sasuke)
Consider the following line
print(return_health(player1.name, player1.health, player1.maxhealth, player1.healthdashes))
You are asking python to print the result of the return_health function. The return_health function doesn't actually return anything so the result of the function is None.
You don't need the print at the start of this line since the return_health function already prints the health information.
Also, it would be better Object Oriented Programming, to make this functionality part of the Player class.
Consider the below change
class Player():
def __init__(self, name, maxhealth, health, healthdashes, offense, jutsu1, jutsu2, jutsu3):
self.name = name
self.maxhealth = maxhealth
self.health = health
self.healthdashes = healthdashes
self.offense = offense
self.jutsu1 = jutsu1
self.jutsu2 = jutsu2
self.jutsu3 = jutsu3
def showhealth(self):
dashConvert = int(self.maxhealth/self.healthdashes)
currentDashes = int(self.health/dashConvert)
remainingHealth = self.healthdashes - currentDashes
healthDisplay = '-' * currentDashes
remainingDisplay = ' ' * remainingHealth
percent = str(int((self.health/self.maxhealth)*100)) + "%"
print(self.name+" "+"|" + healthDisplay + remainingDisplay + "|")
print(" " + percent)
Then when you want to output the health of the player you just call something like
player1.showhealth()
You could also have an "Attack" method for the class.
def attack(self, other_player, chosen_jutsu):
....
If player1 is attacking player 2, this would look like
player1.attack(player2, choice)
return_health returns nothing (None) and that's what you print, because you called print(return_health(...)).
If you expect the function to print stuff on its own (it currently does), better call it print_health and not return_health, and just call it without also printing its (empty) return value.
Ive been learning python recently and am currently working on a small terminal game that has a character move through a maze. Im having a bug where my character is getting stuck and not allowed to move into the open spaces. Ive checked that all my movements the correct directions, and im not sure why the character is stuck.
App
played = player.Player(3, 2)
while True:
board.printBoard(played.rowPosition, played.columnPosition)
selection = input("Make a move: ")
if selection == "w":
if board.checkMove(played.rowPosition - 1, played.columnPosition):
played.moveUp()
elif selection == "s":
if board.checkMove(played.rowPosition + 1, played.columnPosition):
played.moveDown()
elif selection == "a":
if board.checkMove(played.rowPosition, played.columnPosition - 1):
played.moveLeft()
elif selection == "d":
if board.checkMove(played.rowPosition, played.columnPosition - 1):
played.moveRight()
else:
print("Invalid key")
if board.checkWin(played.rowPosition, played.columnPosition):
print("You Win!")
break;
Player:
class Player:
def __init__(self, intitalRow, initialColumn):
self.rowPosition = intitalRow
self.columnPosition = initialColumn
def moveUp(self):
self.rowPosition = self.rowPosition - 1
def moveDown(self):
self.rowPosition = self.rowPosition + 1
def moveRight(self):
self.columnPosition = self.columnPosition + 1
def moveLeft(self):
self.columnPosition = self.columnPosition - 1
Gameboard
class GameBoard:
def __init__(self):
self.winningRow = 0
self.winningColumn = 2
self.board = [
[" * ", " * ", " ", " * ", " * ", " * "],
[
" * ",
" ",
" ",
" ",
" * ",
" * ",
],
[
" * ",
" ",
" * ",
" * ",
" ",
" * ",
],
[
" * ",
" ",
" ",
" ",
" ",
" * ",
],
[" * ", " * ", " * ", " * ", " * ", " * "],
]
def printBoard(self, playerRow, playerColumn):
for i in range(len(self.board)):
for j in range(len(self.board[i])):
if i == playerRow and j == playerColumn:
print("P", end="")
else:
print(self.board[i][j], end="")
print("")
def checkMove(self, testRow, testColumn):
if self.board[testRow][testColumn].find("*") != -1:
print("Can't move there!")
return False
return True
def checkWin(self, playerRow, playerColumn):
if playerRow == 0 and playerColumn == 2:
return True
else:
return False
When the selection is "d" the same cell is being checked as when the selection is "a". I think you meant for one of these to use played.columnPosition + 1.
I'm trying to allow the user to input the # of rows and columns that they'd like in their connect 4 game, so I'm trying to use their input to create the board. I'm trying to create a nested list so that my other code works. I've been trying for the past 2 hours, by searching the web and racking my brains for an answer. Here is the code:
import random
import ast
def winner(board):
"""This function accepts the Connect Four board as a parameter.
If there is no winner, the function will return the empty string "".
If the user has won, it will return 'X', and if the computer has
won it will return 'O'."""
for row in range(7):
count = 0
last = ''
for col in range(7):
row_win = board[row][col]
if row_win == " ":
count = 0
continue
if row_win == last:
count += 1
else:
count = 1
if count >= 4:
return row_win
last = row_win
for col in range(7):
count = 0
last = ''
for row in range(7):
col_win = board[row][col]
if col_win == " ":
count = 0
continue
if col_win == last:
count += 1
else:
count = 1
if count >= 4:
return col_win
last = col_win
for row in range(7):
for col in range(7):
try:
if (board[row][col] == board[row + 1][col + 1] and board[row + 1][col + 1] == board[row + 2][
col + 2] and
board[row + 2][col + 2] == board[row + 3][col + 3]) and (
board[row][col] != " " or board[row + 1][col + 1] != " " or board[row + 2][col + 2] != " " or
board[row + 3][col + 3] != " "):
return board[row][col]
except:
IndexError
for row in range(7):
for col in range(7):
try:
if (board[row][col] == board[row + 1][col - 1] and board[row + 1][col - 1] == board[row + 2][
col - 2] and
board[row + 2][col - 2] == board[row + 3][col - 3]) and (
board[row][col] != " " or board[row + 1][col - 1] != " " or board[row + 2][col - 2] != " " or
board[row + 3][col - 3] != " "):
return board[row][col]
except:
IndexError
# No winner: return the empty string
return ""
def display_board(board):
"""This function accepts the Connect Four board as a parameter.
It will print the Connect Four board grid (using ASCII characters)
and show the positions of any X's and O's. It also displays
the column numbers on top of the board to help
the user figure out the coordinates of their next move.
This function does not return anything."""
# print(" 1 2 3 4 5 6 7")
header = " "
i = 1
while i < len(board) + 1:
header = header + str(i) + " "
i += 1
header = header + str(i)
print(header)
for row in board:
print(" ", " | ".join(row))
print(" ---+---+---+---+---+---+---")
print()
#
# header = " "
# pipe_line = " |"
# separator = "---+"
#
# for row_num in range():
# header = header + str(row_num)
# pipe_line = pipe_line + " " + " | ".join(row))
# separator = separator + "---+"
# print()
def make_user_move(board):
"""This function accepts the Connect Four board as a parameter.
It will ask the user for a row and column. If the row and
column are each within the range of 1 and 7, and that square
is not already occupied, then it will place an 'X' in that square."""
valid_move = False
while not valid_move:
try:
col = int(input("What col would you like to move to (1-7): "))
if board[0][col - 1] != ' ':
print("Sorry, that column is full. Please try again!\n")
else:
col = col - 1
for row in range(6, -1, -1):
if board[row][col] == ' ' and not valid_move:
board[row][col] = 'X'
valid_move = True
except:
ValueError
print("Please enter a valid option! ")
return board
def make_computer_move(board):
"""This function accepts the Connect Four board as a parameter.
It will randomly pick row and column values between 0 and 6.
If that square is not already occupied it will place an 'O'
in that square. Otherwise, another random row and column
will be generated."""
computer_valid_move = False
while not computer_valid_move:
col = random.randint(0, 6)
if board[0][col] != ' ':
print("Sorry, that column is full. Please try again!\n")
else:
for row in range(6, -1, -1):
if board[row][col] == ' ' and not computer_valid_move:
board[row][col] = 'O'
computer_valid_move = True
return board
def main():
"""The Main Game Loop:"""
# free_cells = 42
# users_turn = True
# cf_board = [[" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "]]
cf_board = []
row = int(input("How many rows do you want your game to have? "))
col = int(input("How many columns do you want your game to have? "))
free_cells = col * row
row_str = "\" \""
board_str = "\" \""
i = 0
j = 0
while i < col-1:
row_str = row_str + "," + "\" \""
i += 1
row_str = "'" + row_str + "'"
board_str = row_str + ","
while j < row-1:
board_str = board_str + row_str + ","
j += 1
Input = [board_str]
cf_board = [list(ast.literal_eval(x)) for x in Input]
# for i in range(row-1):
# cf_board.append(row_str)
while not winner(cf_board) and (free_cells > 0):
display_board(cf_board)
if users_turn:
cf_board = make_user_move(cf_board)
users_turn = not users_turn
else:
cf_board = make_computer_move(cf_board)
users_turn = not users_turn
free_cells -= 1
display_board(cf_board)
if (winner(cf_board) == 'X'):
print("Y O U W O N !")
elif (winner(cf_board) == 'O'):
print("T H E C O M P U T E R W O N !")
elif free_cells == 0:
print("S T A L E M A T E !")
print("\n*** GAME OVER ***\n")
# Start the game!
main()
I'd like it to become something formatted like this;
# cf_board = [[" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
# [" ", " ", " ", " ", " ", " ", " "]]
Where the row and col depends on the user. I've tried achieving that, but I only get this huge list that's not separated by the # of rows and columns.
TL;DR
Please help me fix my code at main(), where I'm trying to construct a board with the user's inputs
Please try to ask questions only using a minimal reproducible example. If you are only trying to solve the problem of constructing a board from user input then only post the necessary code relating to that. To generate a list of lists of open spaces you could do something like this.
row = int(input("How many rows do you want your game to have? "))
col = int(input("How many columns do you want your game to have? "))
cf_board = []
rowLst = []
for i in range(row):
for j in range(col):
rowLst.append(" ")
cf_board.append(rowLst.copy())
rowLst.clear()
print(board)
for j in range(col) appends an open space to a new list. After that finishes that list is appended to the main board list and then cleared to go onto the next row.
getting that board is pretty simple. Don't need eval or anything like that.
Just do cf_board = [[" "]*col]*row to put as many space entries and lists inside as you need.
I've completed a Connect 4 game but I want the user to be able to choose the number of rows and columns. Could somebody help me with that? Here is my code: https://paste.pythondiscord.com/iwitecuxum.py Thank you so much! The board can be found under main() and display_board(board)
def main():
"""The Main Game Loop:"""
free_cells = 42
users_turn = True
ttt_board = [[" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
[" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
[" ", " ", " ", " ", " ", " ", " "], [" ", " ", " ", " ", " ", " ", " "],
[" ", " ", " ", " ", " ", " ", " "]]
while not winner(ttt_board) and (free_cells > 0):
display_board(ttt_board)
if users_turn:
ttt_board = make_user_move(ttt_board)
users_turn = not users_turn
else:
ttt_board = make_computer_move(ttt_board)
users_turn = not users_turn
free_cells -= 1
display_board(ttt_board)
if (winner(ttt_board) == 'X'):
print("Y O U W O N !")
elif (winner(ttt_board) == 'O'):
print("T H E C O M P U T E R W O N !")
else:
print("S T A L E M A T E !")
print("\n*** GAME OVER ***\n")
and board
def display_board(board):
"""This function accepts the Connect Four board as a parameter.
It will print the Connect Four board grid (using ASCII characters)
and show the positions of any X's and O's. It also displays
the column numbers on top of the board to help
the user figure out the coordinates of their next move.
This function does not return anything."""
print(" 0 1 2 3 4 5 6")
for row in board:
print(" " + " | ".join(row))
print("---+---+---+---+---+---+---")
print()