I'm trying to make /stop command for the bot (the greetings stop to send). It works, but only one time, after pressing the /start command it is unable to stop again and runs forever.
Tried different methods of stopping, manged either to stop and unable to restart or to stop once and unable to stop after repeating /start or "greet".
I would be very grateful for the advice of how to improve the existing code
import random, telebot, schedule, time
from telebot import types
from config import token
bot = telebot.TeleBot(token)
greetings = ["hello", "Have a nice day", "Goodbye", "Wow"]
#bot.message_handler(commands=['start'])
def start_message(message):
markup = types.ReplyKeyboardMarkup(resize_keyboard=True)
item1 = types.KeyboardButton("Greet")
markup.add(item1)
bot.send_message(message.chat.id, "Press button", reply_markup=markup)
#bot.message_handler(content_types=["text"])
def run_function(message):
def function_to_run():
random_greet = random.choice(greetings)
bot.send_message(message.chat.id, random_greet)
def scheduling():
schedule.every(4).seconds.do(function_to_run).tag('schedule')
scheduling()
if message.text.lower() == "greet":
bot.send_message(message.chat.id, "here you go")
function_to_run()
def schedule_run():
while True:
schedule.run_pending()
time.sleep(1)
schedule_run()
elif message.text.lower() == "stop":
bot.send_message(message.chat.id, "stopping...")
schedule.clear('schedule')
time.sleep(1)
bot.send_message(message.chat.id, "stopped successfully")
bot.polling()
import random, telebot, schedule, time
from telebot import types
from config import token
bot = telebot.TeleBot(token)
greetings = ["hello", "Have a nice day", "Goodbye", "Wow"]
#bot.message_handler(commands=['start', 'stop'])
def start_message(message):
command = message.text.split()[0]
if command == "/start":
markup = types.ReplyKeyboardMarkup(resize_keyboard=True)
item1 = types.KeyboardButton("Greet")
markup.add(item1)
bot.send_message(message.chat.id, "Press button", reply_markup=markup)
elif command == "/stop":
bot.send_message(message.chat.id, "stopping...")
schedule.clear('schedule')
time.sleep(1)
bot.send_message(message.chat.id, "stopped successfully")
exit()
#bot.message_handler(content_types=["text"])
def run_function(message):
...
# or
elif message.text.lower() == "stop":
bot.send_message(message.chat.id, "stopping...")
schedule.clear('schedule')
time.sleep(1)
bot.send_message(message.chat.id, "stopped successfully")
exit()
bot.polling()
if you want to on it again try this:
import random, telebot, schedule, time
from telebot import types
from config import token
bot = telebot.TeleBot(token)
greetings = ["hello", "Have a nice day", "Goodbye", "Wow"]
on = True
#bot.message_handler(commands=['start', 'stop'])
def start_message(message):
global on
command = message.text.split()[0]
if command == "/start" and not on:
on = True
# your code
if command == "/stop" and on:
on = False
# your code
#bot.message_handler(content_types=["text"])
def run_function(message):
global on
if on:
# your code
bot.polling()
Related
I'm trying to get code from user and if it's correct to start sending him options.
But the third function (send_welcome) doesn't start. Could you say what I'm missing?
#bot.message_handler(commands=['start'])
def send_text_request(message):
msg = bot.send_message(message.chat.id, "Write a code")
bot.register_next_step_handler(msg, function)
def function(message):
if message.text=='6':
print('hello')
bot.register_next_step_handler(message, send_welcome)
def send_welcome(message):
markup=types.ReplyKeyboardRemove(selective=False)
markup = types.ReplyKeyboardMarkup(resize_keyboard=True, row_width=2)
itembtn1 = types.KeyboardButton("option1")
itembtn2 = types.KeyboardButton("option2")
markup.add(itembtn1, itembtn2)
msg = bot.send_message(message.chat.id, "Hello "+message.from_user.first_name+", I will help you! \n Enter the product", reply_markup=markup)
I am developing a telegram bot with FSM. It is should've chat-bot for ordering pizza. The conversation should be like this:
What kind of pizza do you want? Big or small?
Great
How will you pay?
In cash
Do you want a big pizza, cash payment?
Yes
Thank you for the order
I've come with this code:
bot.py
import telebot
import config
import FSM
from telebot import types
bot = telebot.TeleBot(config.TOKEN)
fsm = FSM.TelegramBot()
#bot.message_handler(commands=['start'])
def welcome(message):
#keyboard
markup = types.ReplyKeyboardMarkup(resize_keyboard=True)
item1 = types.KeyboardButton("Заказать пиццу")
item2 = types.KeyboardButton("Посмотреть меню")
markup.add(item1, item2)
bot.send_message(message.chat.id,
"Добро пожаловать, {0.first_name}!\nЯ - <b>{1.first_name}</b> бот, я помогу вам "
"сделать заказ.".format(
message.from_user, bot.get_me()),
parse_mode='html', reply_markup=markup)
#bot.message_handler(content_types=['text'])
#bot.message_handler(func=lambda message: fsm.state == 'asleep')
def order_pizza(message):
bot.send_message(message.chat.id, 'Какую вы хотите пиццу? Большую или маленькую?')
fsm.asked_for_payment_method(message.text)
#bot.message_handler(content_types=['text'])
#bot.message_handler(func=lambda message: fsm.state == 'size_selected')
def choose_size(message):
bot.send_message(message.chat.id, 'Как вы будете платить?')
fsm.asked_for_payment_method(message.text)
#bot.message_handler(content_types=['text'])
#bot.message_handler(func=lambda message: fsm.state == 'payment_selected')
def choose_size(message):
bot.send_message(message.chat.id, 'Какой вкус вы хотите?')
fsm.asked_for_flavour(message.text)
#bot.message_handler(content_types=['text'])
#bot.message_handler(func=lambda message: fsm.state == 'flavour_selected')
def choose_size(message):
markup = types.InlineKeyboardMarkup(row_width=2)
item1 = types.InlineKeyboardButton("Да", callback_data='yes')
item2 = types.InlineKeyboardButton("Нет ", callback_data='no')
markup.add(item1, item2)
bot.send_message(message.chat.id, f'Вы хотите {fsm.size} пиццу {fsm.flavour}, оплата - {fsm.pay_method} ?', reply_markup=markup)
#bot.callback_query_handler(func=lambda call: True)
def callback_inline(call):
try:
if call.message:
if call.data == 'yes':
bot.send_message(call.message.chat.id, 'Спасибо за заказ')
fsm.confirmed()
# show alert
bot.answer_callback_query(callback_query_id=call.id, show_alert=True,
text="Заказ оформлен")
elif call.data == 'no':
markup = types.ReplyKeyboardMarkup(resize_keyboard=True)
item1 = types.KeyboardButton("Заказать пиццу")
item2 = types.KeyboardButton("Посмотреть меню")
markup.add(item1, item2)
bot.send_message(call.message.chat.id, 'Бывает 😢', reply_markup=markup)
fsm.confirmed()
# remove inline buttons
bot.edit_message_text(chat_id=call.message.chat.id, message_id=call.message.message_id, text=f'Вы хотите {fsm.size} пицца {fsm.flavour}, оплата - {fsm.pay_method} ?',
reply_markup=None)
except Exception as e:
print(repr(e))
# RUN
bot.polling(none_stop=True)
And this code for Finite State Machine. I've used pytransitions
/
transitions
FSM.py
from transitions import Machine, State
class telegram_bot_state(object):
states = ['asleep',
'size_selected',
'payment_selected',
'flavour_selected']
transitions = [
{'trigger': 'asked_size', 'source': 'asleep', 'dest': 'size_selected', 'after': 'update_size'},
{'trigger': 'asked_for_payment_method', 'source': 'size_selected', 'dest': 'payment_selected', 'after': 'update_payment'},
{'trigger': 'asked_for_flavour', 'source': 'payment_selected', 'dest': 'flavour_selected','after': 'update_flavour'},
{'trigger': 'confirmed', 'source': 'flavour_selected', 'dest': 'asleep'}, ]
def __init__(self):
self.size = ''
self.pay_method = ''
self.flavour = ''
self.machine = Machine(model=self, states=TelegramBot.states, transitions=TelegramBot.transitions, initial='asleep')
def update_size(self, msg):
self.size = msg
print(f'размер задан: {self.size}')
def update_payment(self, msg):
self.pay_method = msg
print(f'способ оплаты задан: {self.pay_method}')
def update_flavour(self, msg):
self.flavour = msg
print(f'Вкус пиццы задан: {self.flavour}')
But the problem is it just runs through everything and doesn't wait for the user's answer. Just send all the questins.
p.s. I'm sorry in advance if wrote something wrong this is my first question.
For sequence use method bot.register_next_step_handler_by_chat_id and create functions with your name of this step. I'm hope this answer is helpful
This question is dated but has been viewed quite often. As of September 2022, I'd say that there is no need for transitions when you write a Telegram bot with pyTelegramBotAPI as it contains means for state-based logic and data storage.
There is a custom state example which illustrates how states can be used. I adapted this example for your use case:
import telebot # telebot
from telebot import custom_filters
from telebot.handler_backends import State, StatesGroup #States
# States storage
from telebot.storage import StateMemoryStorage
# Now, you can pass storage to bot.
state_storage = StateMemoryStorage() # you can init here another storage
bot = telebot.TeleBot("<YOUR TOKEN HERE>", state_storage=state_storage)
# States group.
class MyStates(StatesGroup):
# Just name variables differently
size = State() # creating instances of State class is enough from now
payment = State()
confirmation = State()
#bot.message_handler(commands=['order'])
def order(message):
bot.set_state(message.from_user.id, MyStates.size, message.chat.id)
bot.send_message(message.chat.id, 'What size of pizza do you want? Large or small?')
#bot.message_handler(state="*", commands=['cancel'])
def cancel(message):
bot.send_message(message.chat.id, "Your order was cancelled.")
bot.delete_state(message.from_user.id, message.chat.id)
#bot.message_handler(state=MyStates.size)
def get_size(message):
inp = message.text.lower()
if inp not in ["small", "large"]:
bot.send_message(message.chat.id, 'Please enter "large" or "small".')
return
bot.send_message(message.chat.id, 'How will you pay? Cash or paypal?')
bot.set_state(message.from_user.id, MyStates.payment, message.chat.id)
with bot.retrieve_data(message.from_user.id, message.chat.id) as data:
data['size'] = inp
#bot.message_handler(state=MyStates.payment)
def get_payment(message):
inp = message.text.lower()
if inp not in ["cash", "paypal"]:
bot.send_message(message.chat.id, 'Please enter "cash" or "paypal".')
return
with bot.retrieve_data(message.from_user.id, message.chat.id) as data:
msg = ("Your order details\n---------\n"
f"Size: {data['size']}\n"
f"Payment: {inp}\n---------\n"
f"Is that correct [yes/no]?")
bot.send_message(message.chat.id, msg)
bot.set_state(message.from_user.id, MyStates.confirmation, message.chat.id)
# result
#bot.message_handler(state=MyStates.confirmation)
def confirm_order(message):
inp = message.text.lower()
if inp == "yes":
bot.send_message(message.chat.id, "Great. The order is on its way.")
bot.delete_state(message.from_user.id, message.chat.id)
return
elif inp == "no":
bot.send_message(message.chat.id, "Okay. Let's start again.")
order(message)
return
bot.send_message(message.chat.id, 'Please enter "yes" or "no".')
bot.add_custom_filter(custom_filters.StateFilter(bot))
bot.infinity_polling(skip_pending=True)
I have got a Telegram-bot in AIOgram. My aim in this bot is to run it and if user writes secret phrase - bot must send secret message.
My code in main.py file:
from aiogram.dispatcher.filters import Text
from aiogram.dispatcher import FSMContext
from database import Database
from states import *
from aiogram import Bot, Dispatcher, executor, types
bot = Bot(token="my_token")
dp = Dispatcher(bot)
#dp.message_handler(commands="start")
async def start(message: types.Message):
keyboard1 = types.InlineKeyboardMarkup()
links = ["one", "two", "three"]
for row in links:
button = types.InlineKeyboardButton(text=row[0])
keyboard1.add(button)
await message.answer("Chose the phrase", reply_markup=keyboard1)
# options - is the next handler function
dp.register_message_handler(options, state="*")
async def options(message: types.Message):
if message.text == "Secret phrase":
keyboard = types.ReplyKeyboardMarkup(one_time_keyboard=True)
keyboard.add(types.KeyboardButton(text="Secret 1"),
types.KeyboardButton(text="Secret 2"),
types.KeyboardButton(text="Secret 3"),
types.KeyboardButton(text="Main menu"))
await message.answer("Chose the phrase", reply_markup=keyboard)
dp.register_message_handler(workingWithLinks, state="*")
else:
await message.answer("This command is error, for phrases update call command /update")
async def workingWithLinks(message: types.Message):
if message.text == "Secret 1":
await message.answer("This is secret number 1")
await SecretOne.step_one.set()
elif message.text == "Secret 2":
await SecretTwo.step_one.set()
await message.answer("This is secret 2")
elif message.text == "Secret 3":
await SecretThree.step_one.set()
await message.answer("This is secret 3")
else:
await message.answer("This command is error, for phrases update call command /update")
def register_handlers_common(dp: Dispatcher):
dp.register_message_handler(start, commands="start", state="*")
dp.register_message_handler(start, commands="update", state="*")
if __name__ == "__main__":
register_handlers_common(dp)
executor.start_polling(dp, skip_updates=True)
My code in states.py file:
from aiogram.dispatcher.filters.state import State, StatesGroup
class SecretOne(StatesGroup):
step_one = State()
step_two = State()
step_three = State()
class SecretTwo(StatesGroup):
step_one = State()
step_two = State()
step_three = State()
class SecretThree(StatesGroup):
step_one = State()
step_two = State()
step_three = State()
Scenario of my bot is next: I click command /start, and bot sends me message "Chose the phrase" with three inline-buttons - "one", "two" and "three". And if user don't click on one of this button and type "Secret phrase" - program link user to "options" handler-function. This is string, where linking is:
dp.register_message_handler(options, state="*")
"options" is handler-function. This link works. But, if in "options" I chose the phrase "Secret 1" - link on workingWithLinks handler-function doesn't work.
Linking on workingWithLinks handler-function:
dp.register_message_handler(workingWithLinks, state="*")
Also I tried to link on next handler-function with states as in this tutorial, but this also doesn't works.
How to link on workingWithLinks handler-function?
Don't register message handlers in message handlers!
dp.register_message_handler(options, state="*")
This string will add handler to the stack on every message call.
Answer
If you wanna get something from user - use states.
Look at the FSM example
I'm building a Telegram bot with the library https://github.com/eternnoir/pyTelegramBotAPI
I'm trying to make when I press a menu button, it sends a message to the user.
How could I do it?
import telebot
from telebot.types import InlineKeyboardMarkup, InlineKeyboardButton
TELEGRAM_TOKEN = '<TOKEN>'
bot = telebot.TeleBot(TELEGRAM_TOKEN)
def gen_markup():
markup = InlineKeyboardMarkup()
markup.row_width = 2
markup.add(InlineKeyboardButton("Yes", callback_data="cb_yes"),
InlineKeyboardButton("No", callback_data="cb_no"))
return markup
#bot.callback_query_handler(func=lambda call: True)
def callback_query(call):
if call.data == "cb_yes":
bot.answer_callback_query(call.id, "Answer is Yes")
elif call.data == "cb_no":
bot.answer_callback_query(call.id, "Answer is No")
#bot.message_handler(func=lambda message: True)
def message_handler(message):
bot.send_message(message.chat.id, "Yes/no?", reply_markup=gen_markup())
bot.polling(none_stop=True)
You can use data of your call object as the user id(call.from_user.id) of the sender to send a message:
if call.data == "cb_yes":
bot.answer_callback_query(call.id, "Answer is Yes")
bot.send_message(call.from_user.id,"Your answer was Yes!")
elif call.data == "cb_no":
bot.answer_callback_query(call.id, "Answer is No")
bot.send_message(call.from_user.id,"Your answer was No!")
I'm new in development and python too. I tried to write a simple telegram bot using Telebot. The scenario is to show inline keyboard to user when user click on button do some logic. In Example below I cut the code but it showing the problem. And the problem is:
When first user start working he gets correct and all notifications. But when second user starts to work with bot he gets correct keyboard but notification will send to First user.
Here is a code example:
import telebot
import datetime
bot = telebot.TeleBot(insert_token_here)
keyboard1 = telebot.types.ReplyKeyboardMarkup(True)
keyboard1.row('Choose date', 'dont push it')
#bot.message_handler(commands=['start'])
def start_message(message):
bot.send_message(message.chat.id, 'Welcome', reply_markup=keyboard1)
def dates_inline():
current_date = datetime.datetime.today()
# Inline keyboard
keyboard_dates = telebot.types.InlineKeyboardMarkup()
key_now = telebot.types.InlineKeyboardButton(text=current_date.strftime('%d.%m.%Y') + ' (Today)',
callback_data=current_date.strftime('%Y-%m-%d'))
keyboard_dates.add(key_now)
return keyboard_dates
#bot.message_handler(content_types=['text'])
def choose_message(message):
if message.text == "Choose date":
bot.send_message(message.chat.id, 'Choose date:', reply_markup=dates_inline())
#bot.callback_query_handler(func=lambda call: True)
def choose_date(call):
dt = call.data
print('chose_date dt: %s' % dt)
bot.send_message(message.chat.id, 'All done')
print('end')
else:
print('smth else')
def main():
bot.polling(none_stop=True)
if __name__ == '__main__':
main()
I also faced a similar problem.
Do not create a handler/decorator inside another one. It doesn't work like that. I'm also relatively new to python, so I don't know the exact reason. I also learned it from my mistake.
Do not send messages back to message.chat.id . send it to call.from_user.id so that it'll always send the reply back to the user from whom the call came.
#bot.message_handler(content_types=['text'])
def choose_message(message):
if message.text == "Choose date":
bot.send_message(message.chat.id, 'Choose date:', reply_markup=dates_inline())
else:
print('smth else')
#bot.callback_query_handler(func=lambda call: True)
def choose_date(call):
dt = call.data
print('chose_date dt: %s' % dt)
bot.send_message(call.from_user.id, 'All done')
print('end')
I am also in the development of a bot right now and this is working fine for me.
You need to move following code to top-level indentation. Otherwise it works not as you intended.
#bot.callback_query_handler(func=lambda call: True)
def choose_date(call):
dt = call.data
print('chose_date dt: %s' % dt)
bot.send_message(message.chat.id, 'All done')
#wowkin2 Here is a sample code:
#bot.message_handler(content_types=['text'])
def choose_message(message):
if message.text == "Choose date":
bot.send_message(message.chat.id, 'Choose date:', reply_markup=dates_inline())
print('end')
else:
print('smth else')
#bot.callback_query_handler(func=lambda call: True)
def choose_date(call):
dt = call.data
bot.send_message(message.chat.id, 'All done')