I'm having trouble figuring out this code. I am currently making a script in python where a it's kind of how an arcade machine works when you have 30 seconds to continue and you can insert more coins to go again. The trouble I'm having is I cant get the coins to count up while the timer counts down. Here is my code so far:
while True:
start = GPIO.input(startBtn)
input_state = GPIO.input(counterPin)
if input_state == False:
coins += 1
print(str(coins) + "¢ inserted")
time.sleep(0.09)
if coins == 100:
coins -= 100
creditss += 1
print("You currently have: " +str(creditss) + " credits")
timer = creditss * 5
if start == False:
if creditss > 0:
print("You have: " +str(timer) + " minutes to play!")
print("Have Fun!")
x = timer
for i in range(x + 1):
time.sleep(1)
print(formatTime(x))
x -= 1
timer -= creditss * 5
creditss = 0
if timer == 0:
pause()
timer += 30
print("Continue? : Insert more money to keep playing!")
x = timer
if input_state == False:
coins += 1
print(str(coins) + "¢ inserted")
time.sleep(0.09)
else:
for i in range(x + 1):
time.sleep(1)
print(formatTime(x))
x -= 1
if coins == 100:
coins -= 100
creditss += 1
print(creditss)
if creditss > 0 & timer != 0:
print("Good")
pause()
else:
print("exit")
os.system('/home/pi/exit.sh')
Thanks for any help!
Okay...the best help I can give you is this:
At this point you need to refactor your code. When you get a program with more than two - three levels of nesting (you have four if statements nested) then you should be defining functions and splitting out different parts of your program into logical chunks. This makes debugging easier, as you can drop I/O print statements to see where your script is failing.
To help you know what to split out first - look for sections where you're repeating yourself. If you type it more than once, it deserves its own function (DRY Principle - Don't repeat yourself).
for example you have:
if coins == 100:
coins -= 100
creditss += 1
print("You currently have: " +str(creditss) + " credits")
timer = creditss * 5
and
if coins == 100:
coins -= 100
creditss += 1
print(creditss)
This functionality is extremely similar and can likely be split off into a function. The other thing you want to think about: You only want /one/ part of the program to be able to change the number of coins so that you know when you're calling it what's happening (explicit is better than implicit). That should be a function and anything that needs to operate it can call it. The easier your program is to read, the easier it will be to debug. At least until you get issues that silently fail.
The sleep function stops execution, so during countdown every time you sleep you stop checking the GPIO state for a whole second and then just check it once more until sleeping again for another second. For this strategy to work you need to be checking your input very fast as to not miss a fast event. My guess is that checking once every one second is probably not enough for what you are doing.
A sightly better solution would be to not sleep and to use time.clock() to check when the play time has ended. So when the game starts you store the current value of time.clock() and after that you continue checking it until enough time has elapsed. There could still be an input which unsets and sets your input pin faster your loop can detect it so it's not bulletproof.
I don't have experience with python on raspberry-pi but a quick google search shows me there are GPIO.add_event_detect() and GPIO.add_event_callback() functions which can be set up so a callback function is called on a GPIO pin state change, which I would guess relies on interrupts so that you wouldn't miss an event. It could be a good idea to look into that.
Related
I have to do some exercises in my university with Python.So I need to build a quiz game. And the requirements are:
Right answer get +1 point.
Wrong answer get -1 point
The player has to answer each question in 20 seconds. If the player answers with more than 20 seconds, he gets -1 point even his answer is correct.
I just tried with threading and Timer. My code is like this:
from time import *
import threading as th
score = 0
correct_answer = 1
def sctn():
global score
score -=1
print(score)
S = th.Timer(20.0, sctn)
S.start()
answer = int(input("enter : "))
if answer == correct_answer :
score += 1
else:
score -= 1
print(score)
S.cancel()
I set an example for the correct answer. But when I run the code, if I type the correct answer more than 20 seconds, after that the score = -1 + 1 = 0, or if I type the wrong answer more than 20 seconds, the score = -1 -1 = -2.
You have too much code. There are two cases: if the user has entered the correct answer in 20 seconds or less, he gets a point; otherwise he loses one.
The timer function doesn't need to do anything. When you test for the correct answer, you can also test to see if the timer has expired. Timer is a subclass of Thread, therefore it has an function is_alive that returns True if it's still running.
The problem with your original program is that once the timer expires, the answer doesn't matter any more. But you check it anyway, so the -1 point from the timer function gets added to the plus or minus 1 from the answer-checking logic.
from time import *
import threading as th
score = 0
correct_answer = 1
def sctn():
pass
S = th.Timer(20.0, sctn)
S.start()
answer = int(input("enter : "))
if answer == correct_answer and S.is_alive():
score += 1
else:
score -= 1
S.cancel()
print(score)
You can use the after method of tkinter to start a timer when a question is shown, and deduct a score if the user hasn't responded in time. If the user responds in time you can call after_cancel with the return value of after to cancel the job.
For example, when you want to start the timer you would do something like this:
def start_timer():
global after_id
root.after(20000, times_up)
This assumes you have a global variable named root which refers to the root window. Though, you can use any widget for this. What it does is instruct tkinter to call the function times_up in 20 seconds (20,000 milliseconds)
In that function you can reduce the score by one, for example:
def times_up():
global score
score += 1
Then, in the code that processes the user picking an answer, you can stop the timer and prevent the score from doing down:
def user_picked_an_answer():
global after_id
root.after_cancel(after_id)
If this function is called when the user picks an answer, it will compute the new score as well as prevent the timer from ever triggering.
I am new to python and am doing a basic quiz. I'm running into a problem for scoring.
trials = 3
for i in range(trials):
ans_2 = ansTwo()
results.append(ans_2)
if ans_2 in ('c','C'):
print("Good Job",name)
score+=1
break
else:
remaining = trials-i-1
s = '' if remaining == 1 else 's'
print("Oops Try Again? [{0} Chance{1} Remaining]".format(remaining, s))
This is my code and I'm trying to make it that if they do not get the answer the first time they do not get any points, but if they get the answer the first time they get a point.
Just add an if statement before score += 1 that checks if the loop is running for the first time. In your case:
if i == 0:
score += 1
Hey guys I'm doing a program in python. It's a calculation program which gives you two random number from 2 to 10, and then asks you for example how much is 2 * 4.
And if your answer is correct it gives you a point. Now, I want that the program let's the user calculate for 20secs and when 20secs are over, it will show you how much points you have.
My code so far ->
__author__ = 'Majky'
import random
import time
a = random.randint(2, 10)
b = random.randint(2, 10)
print("How much is", a, "times", b)
t = 0
odg = int(input("Answer ?"))
sec = 0
while sec < 20:
if odg == a * b:
print("Correct")
t = +1
print("Incorrect")
print("Your points are", t)
You are going to want to use threading, and open a parallel thread that will calculate that time (maybe by using time.sleep()) and return once done, once it returns, the main thread will stop execution and return the results.
Using sleep() in the main program will just pause execution for that time, which is not what you want from what I understand. You want the user to be able to interact with the program while the timer is running. That is what using threads from the threading module will allow you to do.
Here is a quick example of the use of threading (adjust it if you need anything specific):
import random
import time
def main():
thread_stop = threading.Event()
thread = threading.Thread(target=user_thread, args=(2, thread_stop))
time.sleep(20)
thread_stop.set()
def user_thread(arg1, stop_event):
t = 0
while(not stop_event.is_set()):
a = random.randint(2, 10)
b = random.randint(2, 10)
print("How much is", a, "times", b)
odg = int(input("Answer ?"))
if odg == a * b:
print("Correct")
t += 1
else:
print("Incorrect")
print("Your points are", t)
main()
Here is also an example using signals that stops the user in the middle of an answer if the 20 seconds are up and counts the results. This example uses signals, which is in itself an interesting module to control execution flow, you should check its documentation when you get a chance. I also realized there was another error in your code which I overlooked and has been corrected now in both examples, when you want to increase "t", use "t+=1", since "t=+1" is incorrect, the last expression is just assigning "positive" one to t every time, so is not increased. Cheers!
import signal
t = 0
#Here we register a handler for timeout
def handler(signum, frame):
#print "Time is up!"
raise Exception("Time is up.")
#function to execute your logic where questions are asked
def looped_questions():
import random
global t
while 1:
#Here is the logic for the questions
a = random.randint(2, 10)
b = random.randint(2, 10)
print("How much is", a, "times", b)
odg = int(input("Answer ?"))
if odg == a * b:
t += 1
print("Correct")
else:
print("Incorrect")
#Register the signal handler
signal.signal(signal.SIGALRM, handler)
#Set the timeout
signal.alarm(20)
try:
looped_questions()
except Exception, exc:
print exc
#Here goes the results logic
print("Your points are", t)
Also, don't forget to add to that sanity checks so that invalid user input doesn't break your code. I will leave that to you ;)
You could use the time.sleep(20) function to wait 20 seconds.
This function suspend execution for the given number of seconds. The argument may be a floating point number to indicate a more precise sleep time.
The actual suspension time may be less than that requested because any caught signal will terminate the sleep() following execution of that signal’s catching routine. Also, the suspension time may be longer than requested by an arbitrary amount because of the scheduling of other activity in the system.
you could do something like this, using time.time().
import time
...
start = time.time()
answer = raw_input('enter solution')
finish = time.time()
if finish - start > 20:
#failure condition
else:
#success condition
So I'm making a little python game in class.
Anyways, I have this as a function:
def checkplayerhealth (playerhealth):
while playerhealth < 1000:
if playerhealth < 0:
input ("Looks like you died. Better luck next time! Press any key to exit")
sys.exit()
Whenever I call it, the game stops. Obviously this is because I need to find a way to run the loop, or at least be constantly checking playerhealth and let the rest of the game continue running.
Is there a way to do this?
The statements
while playerhealth < 1000:
if playerhealth < 0:
will put you in an infinite loop if the function was called with anything greater than or equal to 0 and less than 1000. If you want to break that loop, you need code that changes the value of playerhealth in the loop to something that is less than 0 or equal to or greater than 1000.
Perhaps, you meant the function to be:
def checkplayerhealth (playerhealth):
if playerhealth < 0:
input ("Looks like you died. Better luck next time! Press any key to exit")
sys.exit()
I have recently finished a course in Python about a month ago. I am continuing expanding my knowledge on Python by creating programs.
The code below is a program for a Python countdown program. What the program does is that it asks the user to input a count of seconds, minutes, and hours.
Anyways, I noticed 2 Bugs that occur in the program.
First Bug:
If we enter an hour and second count (and no minute count), the program would count the remaining time for that certain hour, but it would not subtract the hour and set the minute back to 59. Instead, it would print the minute as a negative number.
Second Bug:
If we enter an hour, second, and minute count, the program would count the reamaining time. But when the program reaches the very last minute (i.e. 01:00:59), it would skip that minute and go on to the next one (i.e. 00:59:59).
About the 2nd Bug: Suppose I enter 1 Hour, 1 Minute, 5 Seconds. It would count down the 5 Seconds. The computer would then print 1:00:00. Instead of counting down the seconds for that certain minute. It would skip to 0:59:59. Hope that helps
It would be fantastic if I could receive some assistance with fixing these two bugs, and maybe a way to differently format the program.
Thanks for reading and I am looking forward to your answer,
-Anonymous
import time
time_count = 0
second = int(raw_input("Seconds:"))
count_minute = int(raw_input("Minutes:"))
count_hour = int(raw_input("Hours:"))
time_count += second
time_count += count_minute * 60
time_count += count_hour * 3600
def clean():
global second
global count_minute
global count_hour
print_second = str(second).zfill(2)
print_minute = str(count_minute).zfill(2)
print_hour = str(count_hour).zfill(2)
print "%s:%s:%s" % (print_hour, print_minute, print_second)
time.sleep(1)
clean()
time.sleep(1)
for i in range(1, time_count + 1)[::-1]:
if second == 0 and count_minute == 0 and count_hour == 0:
clean()
break
elif second != 0:
second -= 1
elif second == 0:
count_minute -= 1
second = 59
if count_minute == 0 and count_hour > 0:
clean()
count_hour -= 1
count_minute = 59
clean()
time.sleep(1)
print """
Timer Finished.
"""
Some problems in your code are, the unnecessary use of globals, direct typechecking, etc. Also if you use higher level constructions(like timedelta objects) the probability of your code being bug free is higher. This is better:
from datetime import timedelta
from time import sleep
while True:
try:
hours, minutes, seconds = input('Enter hours, minutes, seconds (with a comma in between): ')
except (ValueError, TypeError): # other errors
print("Error 1, please ...")
continue
except NameError:
print("Error 2")
continue
else:
print("All good")
break
total = timedelta(hours=hours, minutes=minutes, seconds=seconds)
for passed_seconds in range(int(total.total_seconds())):
print total - timedelta(seconds=passed_seconds)
sleep(1)