I'm currently making a text-based game about walking through an abandoned house, and finding items to ward of monsters and all of that. I want a while loop system where if your health reaches below 0 (health=20), then the code ends by saying "You died to (insert event here)". I'm new to coding with python, so I'm not entirely sure how to code that.
I've tried setting up a while loop with an if statement that checks if the health is below 0. This is near the top of the code below the variables and above the functions
health = 20 #variable
while ( health < 0):
print("You died to [insert event here]\n")
break
Instead of it doing anything, it completely ignores it. I'm not sure how I would place the code into the function because I still need to use "global" to import variables into them. If you know the answer to this problem, or you know an alternative code to solve this problem, please tell me. Again I'm new to python so please explain in a way I can understand.
First off, the global keyword is only to give a function write access to a variable. They can always read variables which have been declared outside the scope of any other class/function.
What I think you want is the following:
check health
run the rest of the code
check health
run the rest of the code
ad infinitum...
What you are currently doing, as described, is:
check health
run the rest of the code
How you're going to do this is:
while(health > lower_limit):
[the rest of the code]
print("you died") # game over
In this way, "while the health is above the lower limit, [the rest of the code] will run".
You may write it as:
health = 20
while health > 0:
print("You died to XYZ")
health -= 1
This will print "You died to XYZ" 20 times as loop will run for 20 times from health = 20 to health = 0.
But, while health < 0 would consider it to be zero outcome because python understand loop to run till health reaches zero.
I don't think this is a good place to explain in detail why that code doesn't work. Instead, consider the following game as an example:
def adventure_around(pit_limit = 5, initial_position = 0):
position = initial_position
lived = False
print("Try not to die, noob!")
while position < pit_limit:
direction = input("Which way would you like to go? [n,s,e,w, or q]:")
if direction not in ['n', 's', 'e', 'w', 'q']:
print("Please choose a direction.")
continue
if direction == "n":
position += 1
if direction == 's':
position -= 1
if direction == "q":
print("Coward! (You lived, though.)")
lived = True
break
if not lived:
print("You fell into a pit and died while bravely wandering about! RIP")
adventure_around()
Feed that to your python interpreter and play around with it. (Minutes of fun!) Then study the code. (Googling isn't cheating, either!) What does the while keyword do? How is information from the outside code conveyed to the function? Why are there two ways to exit the while loop? Was that a good idea? Is there a better way to update the position? Did lived need to be initialized? Why or why not? Go ahead and modify it to suit your purpose, if you can. While I don't think a global health variable is the best way to go, try to change the code so that it uses the global keyword to reference a global health variable. What error messages did you get while getting that to work? How would you manage that in a much larger game with tens, hundreds, or thousands of files?
Good hunting!
Related
I am making a small text-based game in Python. It involves many inputs and so to avoid bugs, there are a few things I have to check every time an input exists. Naturally, to speed up the process I wanted to put the code into a def in order to simplify the writing process. When I put the code in the def, it red underlines the continue and break commands (meaning they are incorrect), and if you run the code using the def name, a Traceback occurs. I have tried putting the def section at the beginning of the program, after the while True: (The program is supposed to run infinitely until a certain action is taken that breaks the loop) I have also made sure to try putting it under any variables referenced and in the loop so that no part of it is not defined and so that everything would work if I were to just put the code in there.
Here is the code I am trying to put into a def.
def input_bugs():
if letter_one.lower() == "done" and total_count == 0:
print("You have to play at least one game!")
continue
elif letter_one.lower() == "done":
break
elif len(letter_one) > 1:
print("Sorry, you gotta pick a single letter, no more. Otherwise, type 'done' to end the game and see your stats.")
continue
Here is the Traceback I get every time I try to run it.
line 20
continue
^^^^^^^^
SyntaxError: 'continue' not properly in loop
At this point, I don't even care if I have to write it out every time, I can just copy and paste. I am simply curious as to why it doesn't work so that I know in the future. In case you could not tell, I am pretty new to programming so I want to learn from any mistake I make. Also sorry if I referred to some things in the wrong way. Hopefully, you understood what I meant.
I am trying to make a small text-based adventure game in Python IDLE, but I am running into some issues with having the game give a different response if the player rolls above or below the DC of a DND style preception check. I am very new to this so it's probably an easy fix. Here's the code.
I have no idea how to input the code into the question correctly so here is a picture.
BTW I did import random at the beginning of the code its just too far back to include in the screencap.
Your problem is you are not specifying what numbers the random module to choose from, in the line if random.randint > 10:. To fix this, put the numbers you want it to choose between. For example, if you want it to choose a random number between 1 and 20, your line would become if random.randint(1,20) > 10:.
You will also want to do this for the other line, which reads if random.randint < 10:.
welcome to SO,
Please read the minimal reproducible example guide posted in the comments by D.L. First thing I would do is to post the actual code, because if the link expires, then others viewing this post with a similar issue cannot figure out what was the given example, and how it was solved.
With logistics out of the way, to fix the error you are specifically receiving is to put what is rolled in a variable.
Here are a few things I would change to make your code clear
# Some string that receives yes or no
room_2_input = ("...")
# if condition is yes
if room_2_input == 'yes':
# Put it in a variable
roll = random.randint(1,20)
# You do not have to format a string this way, but I think it makes it easier
print('You rolled {}'.format(roll)
# Put this condition within the first if, because you don't
# need to execute it if they do not choose to roll
# Neither of your original condition has inclusivity, so if 10 is rolled,
# your program will do nothing, because neither condition would be met
if roll >= 10:
'''do stuff'''
# I would only include elif < 10 if you are specifically looking for > 2
# outcomes, but your outcome appears to be binary, either above or below 10
else:
'''do stuff'''
The reason you would not do a random.randint(1,20) > 10: check in your second if statement is because you would be executing a different roll than your first one.
I'm reading a beginners text on Python Programming. And I'm getting a syntax error that, seemingly, is a typo in the text. The code is:
class LaserWeaponArmory(Scene):
def enter(self):
print(dedent("""
You do a dive roll into the Weapon Armory, crouch and scan
the room for more GOthon that might be hiding. It's dead
quiet, too quiet. You stand up and run to the far side of
the room and find the neutron bomb in its container.
There's a keypad lock on the box and you need the code to
get the bomb out. If you get the code wrong 10 times then
the lock closes forever and you can't get the bomb. The
code is 3 digits.
"""))
code = f"{randint(1,9)}{randint(1,9)}{randint(1,9)}"
guess = input("[keypad]> ")
guesses = 0
while guess != code and guesses <10:
print("BZZZZEDDD!")
guesses += 1
guess = input("[keypad]> ")
if guess == code:
print(dedent("""
The container clicks open and the seal breaks, letting
gas out. You grab the neutron bomb and run as fast as
you can to the bridge where you must place it in the
right spot.
"""))
return 'the_bridge'
else:
print(dedent("""
The lock buzzes one last time and then you hear a
sickening melting sound as the mechanism is fused
together. You decide to sit there, and finally the
Gothons blow up the ship from their ship and you die.
"""))
return 'death'
I'm getting the following error:
File "ex43.py", line 121
code = f"{randint(1,9)}{randint(1,9)}{randint(1,9)}"
^ SyntaxError: invalid syntax
So it seems to be trying to create a 3 digit pattern of random numbers?
f strings are supported from python 3.6+
try:
code = "".join([str(randint(1,9)) for _ in range(3)])
And you might want to use randint(0,9) to get also zeros
"randint" module is not imported. Add the following statement
from random import randint
choice="y"
again="y"
coin=0
credit=0
allowed=[0,10,20,50,100,200]
def money_insert():
global again
global coin
global credit
global allowed
while again=="y":
try:
coin=int(input("insert coin"))
except:
print("thats not a coin")
while coin not in allowed:
print("invalid coin")
coin = 0
credit+=coin
again=input("another coin y/n?")
money_insert()
print("you have",credit,"p")
print("")
print("**********")
print("**1 coke 100p**")
print("*2 haribo 100p*")
print("*3 galaxy 100p*")
print("**4 mars 100p**")
print("*5 crisps 50p*")
selection=int(input("what would you like? 1-5"))
while choice=="y":
if selection==1:
if credit>99:
print("Here's your coke")
credit-=100
else:
print("not enough credit")
money_insert()
The last bit keeps displaying not enough credit continuously and I don’t know what to do
Sorry if this is a really dumb question I’m really new to python
choice is never altered, so you can never escape the while choice='y': loop. Then assuming the selection chosen was 1 you continue on to buying your coke. If you have previously entered coins via the money_insert function, presumably you would have at some point answered no to the question "another coin y/n?". You never reset the again variable, so subsequent calls to money_insert will just skip your for loop and not let you enter more money. You then basically follow the same path over and over again: while choice='y': → if selection==1: → if credit>99: ... else: → print("not enough credit")
I should also like to point out the issue with your money_insert function is a direct result of using a global variable where you don't need to. Global variables can be useful in certain instances, but they are generally frowned upon for cases such as this where you generally assume running a function with the same inputs will give the same result, but since the global variable has changed, the function now behaves differently. In this instance you don't need again to be global because it isn't used anywhere else, so you can move again='y' inside the function definition and remove the line global again to solve that particular issue. The same applies to coin and allowed as they aren't used anywhere but inside the function, and although they aren't causing a problem at the moment, leaving them available outside the function to be changed could cause a problem if you try to name something else by the same name somewhere else.
I would like to know why this code does not work; it should exit at the "GAME OVER" point, but it continues to my next defined function.
I have tried other variations on exit() such as: sys.exit(), quit() and SystemExit.
run_attack = input("What do you do: Run/Attack\n")
run = ['run', 'Run', 'RUN']
attack = ['attack', 'Attack', 'ATTACK']
run_attack = 1
while run_attack < 10:
if run_attack == ("run") or ("Run") or ("RUN"):
print ("You turn to run from the wolf but he quickly pounces
you...")
time.sleep(2)
print("You are quickly ripped apart and just about get to see
yourself be eaten.")
print("GAME OVER")
break
exit() #This is where the game should exit, yet after input it
continues to the next function
elif run_attack == ("attack") or ("Attack") or ("ATTACK"):
print("You brace yourself for a bite and have no time to reach"
"for any kind of weapon form your backpack.")
time.sleep("2")
input("You clock the dog hard, twice on the muzzle.")
print("The dog recoils in pain and retreats back to the woods.")
print("You quickly start running as you assume there will be a den in the woods.")
break
else:
input("Type Run or Attack...")
You have several problems in your code; why did you write this much without testing it?
First, you read the user's input, immediately replace is with 1, and then try to test it (incorrectly) as if it were still a string. Your posted code has several syntax errors, so I have some trouble reproducing the problem. However, the immediately obvious problem is here:
break
exit() # This is where ...
You can't get to the exit statement, as you break from the loop just before you can get there.
I strongly recommend that you back up to a few lines and use incremental programming: write a few lines at a time, debug those, and don't continue until they do what you want.
Also look up how to test a variable against various values. Your if statement is incorrect. Instead, try the list inclusion you're trying to set up:
if run_attack in run:
...
elif run_attack in attack:
...
I took the liberty of rewriting your whole program to show you a few things wrong with it and a few tricks. I've done it without the loop, since you never use it anyway... you can add the while loop later once you've mastered it, but you should really go back to basics on some things here:
run_attack = input("What do you do: Run/Attack\n")
if run_attack.lower() == "run":
print("""some
stuff
with
multiple
lines and GAME OVER""")
exit()
elif run_attack in ("attack", "Attack", "ATTACK"):
print("""some
stuff
with
multiple
lines""")
else:
input("Type Run or Attack...")
Some notes:
Using """ for strings enables you to write multiple lines without multiple print statements
Using str.lower() on strings makes everything easy to compare because you only have to compare it to the lowercase version of each string. However for attack you can notice I used a different inclusion test, without multiple conditions. Either way works here.
Like the other answer here (and many comments), you should use only exit() to leave the program entirely, or only break to exit the loop and continue to other code that's beneath the entire loop.
When you rewrite your loop, with a condition like while number_of_turns < 10 don't forget to add 1 to the number of turns on each loop, otherwise that condition is always True and you'll have an infinite loop...
I'm actually quite surprised this code had any resemblance to the behavior you expected from it, my suggestion is to go back over to the basics of python, learn loops, string methods, basic commands. The rest is already said in the other answer here (which is better than mine, frankly) just wanted to add some ideas.