So, my problem is that this code I front for pygame (show below) detects key presses and sometimes doesn't. The code's function is to display a random string of letters and the game is won or lost based on if the letters are pressed in the right order. The problem arises when the code randomly doesn't pick up on some of the key presses, and especially doesn't work when a key is held down. When a key is held down, the game dispalys that a key is being presses, but is unable to say what that key is. I'm sure there is a simple solution this this, but I cannot figure it out.
letters = ['w', 'a', 's', 'd', 'e']
random.shuffle(letters)
print(letters)
number = 0
smthnghppnd = 'n'
while number < 5:
for event in pygame.event.get():
if event.type == pygame.KEYDOWN and number < 5 and smthnghppnd == 'n':
print('down')
print(event.unicode)
if event.unicode == '':
pass
elif event.unicode == letters[number]:
print(letters[number])
number += 1
smthnghppnd = 'y'
else:
print('no ' + letters[number])
number = 7
if len(pygame.event.get()) == 0 and smthnghppnd == 'y':
smthnghppnd = 'n'
print('up')
if number == 7:
print('lose')
else:
print('win')
It looks like the subprocess in pygame is not working correctly. The code does look right, so I suggest you post a runnable script as #Mike67 said. If not instead of using pygame.KEYDOWN try using keyboard or pyautogui module.
They are available here.
https://pypi.org/project/keyboard/
https://pypi.org/project/PyAutoGUI/
Thanks sloth, it was as simple as changing the
if len(pygame.event.get()) == 0 and smthnghppnd == 'y':
to
if smthnghppnd == 'y' and len(pygame.event.get()) == 0:
Since it isn't running pygame.event.get() multiple times per frame, it works perfectly.
Related
I'm trying to pass the event to another function and I need the key constant as a string. Is there a way to get it?
pygame.key.name(ev.key) just gives me Up instead of K_UP
I did try pygame.key.key_code(pygame.key.name(ev.key)) but looks like sdl2 doesn't have that function.
Here's a very valid use case for it:
I already have this function that gets the pressed button's key and does something with it, and it accepts a string. Since It's already working, I wanted to keep it simple and use the same function.
def input(self, key):
for i in self.moves:
if key in i.keys:
i.change("_correct")
else:
i.change("_wrong")
self.next()
return
And I didn't come on saying: There should be a function to do this or that, I just asked if there's a way like getting the value from some dictionary that already exists.
You have to ask yourself why you want to do this? For what purpose? What is wrong with ev.key? Of course SDL does not have this function, because it has no use. ev.key contains a number and the key constants (K_*) are also numbers. So you can compare them. But the event object has no reference to the corresponding key constant.
What you are actually trying to do is
a = 5
b = a
and then you want to get the name "a" from b. This is not possible.
Anyway, you can try to calculate the name manually:
name = pygame.key.name(event.key)
kName = 'K_' + (name if len(name)==1 else name.upper())
example:
while run:
clock.tick(100)
for event in pygame.event.get():
if event.type == pygame.QUIT:
run = False
if event.type == pygame.KEYDOWN:
name = pygame.key.name(event.key)
kName = 'K_' + (name if len(name)==1 else name.upper())
print(pygame.key.name(event.key), kName)
output:
up K_UP
w K_w
right K_RIGHT
d K_d
down K_DOWN
s K_s
left K_LEFT
a K_a
The problem is that when I made it without the run of functions it worked fine, however it seems to now always reset back to 0. I have missed off other bits of code, but it will load the first function then when it comes out of the second function it resets back to 0.
if letter == "G":
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_g and x > 192 and x <250:
score += 1
texts(score,gameDisplay)
def texts(score,gameDisplay):
font=pygame.font.Font(None,100)
scoretext=font.render(str(score), 1,(204,0,204))
gameDisplay.blit(scoretext, (313, 617))
return score
do a score=0 before the for loop.
if letter == "G":
score=0
for event in...
EDIT:
you should initialize the score somewhere outside of the game loop
For some reason, my Player sprite is not moving when I press the arrow keys.
It was moving before, but now it does not move at all, and I don't see any problems
with the code I'm using (plus, no exceptions are raised). Here is the relevant code
(tell me if I need to add more):
def move(self,up,down,right,left): #move function in Player class
if up and self.rect.y>0:
print'up'
self.rect.y-=self.speed
if down and self.rect.y<650:
print'down'
self.rect.y+=self.speed
if right and self.rect.x<650:
print'right'
self.rect.x+=self.speed
if left and self.rect.x>0:
print'left'
self.rect.x-=self.speed
...
#in while loop, under "for event in pygame.event.get():"
elif event.type == 2: #pygame.KEYDOWN
if event.key in range(273,277): #if the key is an arrow key
if event.key==273: #up
up=True
elif event.key==274: #down
down=True
elif event.key==275: #left
right=True
else: #right
left=True
Neither of the following answer my question:
This,
or this
I am on Windows 10, python 2.7.
Let's look at your block of code inside the for loop nested in the while loop.
Is the while loop infinite, or rather, does it stop when you don't want it to?
Also, are you calling the move function directly after the if statement, and after you do so, are you resetting the variables for the directions?
Like this:
#in while loop, under "for event in pygame.event.get():"
elif event.type == 2: #pygame.KEYDOWN
if event.key in range(273,277): #if the key is an arrow key
if event.key==273: #up
up=True
elif event.key==274: #down
down=True
elif event.key==275: #left
right=True
else: #right
left=True
move(up,down,left,right)
up,down,right,left=False,False,False,False
Hopefully, this helps you track down your mistakes.
This question already has an answer here:
How to get text input from user in Pygame? [duplicate]
(1 answer)
Closed 5 years ago.
I want to take input from the user in the game (e.g. their name), then put it on the screen.
I tried modules (including InputBox), but none of them are working. They just displayed my text on screen.
I want to save that input to a variable. Is there any way to do this?
Example:
font1 = pygame.font.SysFont("None", 30)
score = 0
text = font1.render("{}".format(score), True,(255,255,255))
...
...
if sneakeattheapple:
score += 1
text = font1.render("{}".format(score), True,(255,255,255))
...
...
screen.blit(text,(275,6))
This is going to put the score variable on the screen. But score is already defined, I want to do this with a variable given by user.
EDIT: Let me be more clear. In Python we can do this:
x = input("Do you want to do this? (y/n): ")
if x == "y":
#do something
if x == "n":
#do something
This is what I want to do in Pygame.
There's nothing baked into Pygame for this. You will either need to use a 3rd-party GUI library, or build it yourself. Example: if the textbox has focus, take all keydown events, and append to a string. Each frame, draw a box, then draw the string on top.
Building a simple one shouldn't be that hard, but if you want a more full-featured one, it will likely be easier to use a library.
I am currently assuming this function worked with your program is successful and raises no errors. Here is a function in the link you gave us:
def ask(screen, question):
"ask(screen, question) -> answer"
pygame.font.init()
current_string = []
display_box(screen, question + ": " + string.join(current_string,""))
while 1:
inkey = get_key()
if inkey == K_BACKSPACE:
current_string = current_string[0:-1]
elif inkey == K_RETURN:
break
elif inkey == K_MINUS:
current_string.append("_")
elif inkey <= 127:
current_string.append(chr(inkey))
display_box(screen, question + ": " + string.join(current_string,""))
return string.join(current_string,"")
It looks like this is how you get input from a user with a pygame screen right? Let's look at line 4 of this function:
current_string = []
The stuff the user types in is stored in this list. Assuming you know how to take a string and put it on the screen, you could save the string like this:
string_input = ''.join(current_string)
If you can make a similar function (if this one doesn't work), you can do the same thing! Just save the first item in the list holding the string in a variable as shown above. If you have any problems, please comment so I can edit my answer. To the next part now. You can simply activate this function at any time. You might want to activate when something happens. An example is when the snake eats the apple. You probaly have a function for that I believe. You can make a variable like this :
Eat = 0
And put in that function. When that variable is equal to 0. Nothing really activate the other function. When the snake eats the apple, reset the variable to 1 and then activate the function like this:
if Eat = 0:
someclassname.ask()
You do this with many other occasions. I hope this is clearer and more helpful!
Have you tried getting key event's and then putting them together to form something? You could put something like this inside of your main game loop.
input = ''
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_ESCAPE:
playing = False
if event.key == pygame.K_w:
input = input + "w"
if event.key == pygame.K_s:
input = input + "s"
if event.key == pygame.K_a:
input = input + "a"
Then you can check for when the user is done with input(button/enter key), and finalize the variable.
With this you might run into a problem where the key is held longer so you get 3 w's for only pressing the button once. If this is the case you can either 1. not allow another input until a certain time has passed(.25 s maybe?) or 2. use pygame.KEYUP instead of pygame.KEYDOWN and exclusively check for strokes.
Here is a possible solution, it may be really useful for future visitors that are also suffering with this problem like me. Which is;
First making a text-render function
def text1(word,x,y):
font = pygame.font.SysFont(None, 25)
text = font.render("{}".format(word), True, RED)
return screen.blit(text,(x,y))
Then a function works like input;
def inpt():
word=""
text1("Please enter your name: ",300,400) #example asking name
pygame.display.flip()
done = True
while done:
for event in pygame.event.get():
if event.type==pygame.QUIT:
pygame.quit()
quit()
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_a:
word+=str(chr(event.key))
if event.key == pygame.K_b:
word+=chr(event.key)
if event.key == pygame.K_c:
word+=chr(event.key)
if event.key == pygame.K_d:
word+=chr(event.key)
if event.key == pygame.K_RETURN:
done=False
#events...
return text1(word,700,30)
As you see, this function catching keyboard events, it has its own while loop also, it's important. I break the loop when pressing Enter button which is if event.key == pygame.K_RETURN: done=False . Then returning our word with text1 function, displaying. Other events can be set of course opinion-based, like space button for a gap etc.
Then, actually we have to make an intro function and we will ask the user's name in there for example, when intro function is done, name goes to set on the screen until game is over.
def game_intro():
intro=True
while intro:
for event in pygame.event.get():
if event.type==pygame.QUIT:
pygame.quit()
quit()
if event.type==pygame.KEYDOWN:
if event.key==pygame.K_RETURN:
intro=False
inpt() #Here we are calling our function
screen.fill(white)
pygame.display.update()
clock.tick(15)
See that we break this loop with the Enter button again. So we will ask the user our question in intro, then we will set it on the screen, top-right corner for example.
I've found two related questions:
Pygame hold key down causes an infinite loop
pygame - on hold button down
But I want to be specific. How to?
while not done:
for e in event.get():
if e.type == KEYDOWN:
keys = key.get_pressed()
if e.type == QUIT or keys[K_ESCAPE]:
done = True
if keys[K_DOWN]:
print "DOWN"
When I press the down arrow, it prints, but it prints just once. If I want to print it another time, I need to press it again.
If I use the while keyword instead,
while keys[K_DOWN]:
print "DOWN"
I get an infinite loop for some obscure reason.
This logical alternative is also useless:
if ((e.type == KEYDOWN) and keys[K_DOWN]):
print "DOWN"
And there is this other one that somehow cleans the events and you can use while:
while not done:
for e in event.get():
if e.type == KEYDOWN:
keys = key.get_pressed()
if e.type == QUIT or keys[K_ESCAPE]:
done = True
while keys[K_DOWN]:
print "DOWN"
event.get()
keys = key.get_pressed()
But you press the down key for less than one second and it prints thousands of times. (Moving a player would be impossible, and adjusting clock for this does not seem to be the right way to deal with it (And I've tried and I've failed miserably.)).
To press and execute the block thousands of times is useless. What I want, is to press the key and keep going with the action while I don't release it, within the defined game clock speed.
Don't mix up event.get() and key.get_pressed().
If you press or release a key, and event is put into the event queue, which you query with event.get(). Do this if you're actually interested if a key was pressed down physically or released (these are the actual keyboard events. Note that KEYDOWN get's added multiple time to the queue depending on the key-repeat settings).
Also, there's no need to query the state of all keys while handling a KEYDOWN event, since you already know which key is pressed down by checking event.key
If you're interested in if a key is hold down (and ignoring the key-repeat, which you probably want), then you should simply use key.get_pressed(). Using a bunch of flags is just unnecessary and will clutter up your code.
So your code could simplified to:
while not done:
keys = key.get_pressed()
if keys[K_DOWN]:
print "DOWN"
for e in event.get():
pass # proceed other events.
# always call event.get() or event.poll() in the main loop
I am not familiar with Pygame, but, as I see, the program in it should have an event-based architecture. Unless you get the incoming events and process them, nothing happens. That's why your simple loop becomes infinite: it just does not process events.
while keys[K_DOWN]: # Nobody updates the keys, no events are processed
print "DOWN"
Then concerning the get_pressed() call. What it returns is a list of keys. So, you are trying to just loop until the key is released. That's a problem. According to this, pygame.event.get() returns immediately even if there are no events in the queue. The call to get() means: my code still has what to do, but I don't want to block the events, so please process the pending events before I continue. If your code is just waiting for an event, that means it has nothing to do.
The function to WAIT (without blocking the inner loop of Pygame) for an event is pygame.event.wait() (the logic is: I have nothing to do in my code until something happens). However, if you use it, you will have to get information about keys pressed or released from the event itself, not from get_pressed().
Here is an example from the comments to the doc page:
for event in pygame.event.get() :
if event.type == pygame.KEYDOWN :
if event.key == pygame.K_SPACE :
print "Space bar pressed down." #Here you should put you program in the mode associated with the pressed SPACE key
elif event.key == pygame.K_ESCAPE :
print "Escape key pressed down."
elif event.type == pygame.KEYUP :
if event.key == pygame.K_SPACE :
print "Space bar released."
elif event.key == pygame.K_ESCAPE :
print "Escape key released." #Time to change the mode again
I like to take a slightly different approach to this problem. Instead of checking if the key is pressed and taking some action when it is, set a flag on key down and unset it on key up. Then in the function to update the player's position, check the flag and update accordingly. The following pseudo-Python explains what I'm getting at:
if down_key_pressed:
down_flag = True
elif down_key_released:
down_flag = False
elif right_key_pressed:
etc...
This should be done in a separate loop that takes the player's input. Then in update_player_position() you can do:
if down_flag:
move_player_down()
elif right_flag:
move_player_right()
This example assumes four-directional movement, but you could extend it to eight-directional fairly easily by just using if down_flag and right_flag instead.
You can get keydown event repeatedly if you use pygame.key.set_repeat(# millisecond) to set the time limitation for each key event. Quote: when the keyboard repeat is enabled, keys that are held down will generate multiple pygame.KEYDOWN events. The delay is the number of milliseconds before the first repeated pygame.KEYDOWN will be sent. After that another pygame.KEYDOWN will be sent every interval milliseconds. If no arguments are passed the key repeat is disabled. When pygame is initialized the key repeat is disabled. please see following link for detail http://www.pygame.org/docs/ref/key.html#pygame.key.set_repeat
I am using a different approach on holding down a key that I am using in the specific task of moving an object left or right.
I do not care about the computer knowing that a key is actually held down.
When I press a key, a variable that I define for that key (EG: left arrow) is set to True.
Until that key is unpressed (with the event pygame.KEYUP) the "movement to left" is performed.
Dominik's solution is the perfect one (separating event.get() from the keyboard ones). It works perfectly! Finally, no more problems with pygame's input.
Flags:
flag = False # The flag is essential.
while not done:
for e in event.get(): # At each frame it loops through all possible events.
keys = key.get_pressed() # It gets the states of all keyboard keys.
if e.type == QUIT:
done = True
if e.type == KEYDOWN: # If the type is KEYDOWN (DIFFERENT FROM "HELD").
if keys[K_DOWN]: # And if the key is K_DOWN:
flag = True # The flag is set to true.
elif e.type == KEYUP: # The very opposite.
if keys[K_DOWN]:
flag = False
if flag == True: # DON'T USE "while flag == true", it'll crash everything. At every frame, it'll check if the flag is true up there. It's important to remember that the KEYDOWN worked ONLY ONCE, and it was enough to set that flag. So, at every frame, THE FLAG is checked, NOT THE KEYDOWN STATE. Every "player movement" while a key is being held MUST be done through flags.
print "DOWN"
This is basically How I did it, well Go to www.cswonders.com, and it might help you . Go to level 3, then 3.6, and go through the tutorial. I learned it from there. Here is my code.
def update(self):
self.speedx = 0
self.speedy = 0
# If left or right key is pressed, move left or right
pressed_key = pygame.key.get_pressed()
if pressed_key[pygame.K_LEFT]:
self.speedx = -10
if pressed_key[pygame.K_RIGHT]:
self.speedx = 10
if pressed_key[pygame.K_UP]:
self.speedy = -10
if pressed_key[pygame.K_DOWN]:
self.speedy = 10
self.rect.x += self.speedx
self.rect.y += self.speedy
# No further move if off screen
if self.rect.right > SCREEN_WIDTH:
self.rect.right = SCREEN_WIDTH
if self.rect.left < 0:
self.rect.left = 0